Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(createEeventHook): auto dispose #2518

merged 2 commits into from Dec 16, 2022

feat(createEeventHook): auto dispose #2518

merged 2 commits into from Dec 16, 2022


Copy link

call off function onScopeDispose


Improve createEventHook by calling off function in onScopeDispose hook

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • [ X] Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

call off function onScopeDispose
@antfu antfu changed the title Update createEventHook feat(createEeventHook): auto dispose Dec 16, 2022
@@ -29,6 +29,10 @@ export function createEventHook<T = any>(): EventHook<T> {

const on = (fn: (param: T) => void) => {

onScopeDispose(() => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onScopeDispose(() => {
tryOnScopeDispose(() => {

@antfu antfu merged commit fdd4dbf into vueuse:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants