Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useElementBounding): update on scroll #2596

merged 3 commits into from Dec 30, 2022

fix(useElementBounding): update on scroll #2596

merged 3 commits into from Dec 30, 2022


Copy link

@Ducz01 Ducz01 commented Dec 29, 2022


Closes #2319, The Scrolling of useElementBounding didn't work when a div gets scrolled, only when the window was scrolled. Now it works.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

packages/core/useElementBounding/index.ts Outdated Show resolved Hide resolved
@sibbng sibbng changed the title fix: ElementBounding Scroll #2319 fix(useElementBounding): update on scroll Dec 30, 2022
@sibbng sibbng enabled auto-merge (squash) December 30, 2022 17:55
@sibbng sibbng merged commit 268a644 into vueuse:main Dec 30, 2022
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

useElementBounding scroll inside element not working
3 participants