Add getAccountBlocks functionality to the KohaILSDI ILS Driver.
#1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
getAccountBlocksfunctionality to the KohaILSDI.php ILS Driver.Two new sections are added to the KohaILSDI.ini config file to support this:
Blocks - Sets the text used for each of the four Koha account block types (SUSPENSION, OVERDUES, MANUAL and DISCHARGE).
Show_Block_Comment - Sets whether, for each Koha account block type, the related comment will be included in the text shown to the user.
Note: This change uses identical logic to the
getAccountBlocksfunctionality recently added to the Koha.php Driver as Koha's ILSDI APIs don't provide detailed information about blocks (and the KohaILSDI Driver already pulls extra infromation directly from Koha's database for some of it's other functionality).