Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate VuFindPluginInitializer. #1069

Merged
merged 2 commits into from Nov 1, 2017

Conversation

Projects
None yet
1 participant
@demiankatz
Copy link
Member

commented Nov 1, 2017

The functionality provided by VuFindPluginInitializer is not helpful when we upgrade to ServiceManager v3, so we should remove it. The cost of adding complexity to a couple of factories is outweighed by the benefit of eliminating unnecessary overhead on every plugin initialization.

TODO

  • Test everything.

demiankatz added some commits Nov 1, 2017

@demiankatz demiankatz merged commit 26ba981 into master Nov 1, 2017

3 of 4 checks passed

codacy/pr Hang in there, Codacy is reviewing your Pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No new issues
Details
@demiankatz

This comment has been minimized.

Copy link
Member Author

commented Nov 1, 2017

@EreMaijala, this is trivial enough that I don't think it requires your review -- but just a heads-up that we've removed the magic auto-injection triggered by setPluginManager, since it will no longer be possible given the way ServiceManager v3 works, and it doesn't really seem worth the effort anyway (given how rarely it is used).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.