Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable HTTP method for EDS search calls #1627

Merged
merged 15 commits into from Jun 2, 2020
Merged

Configurable HTTP method for EDS search calls #1627

merged 15 commits into from Jun 2, 2020

Conversation

demiankatz
Copy link
Member

@demiankatz demiankatz commented May 22, 2020 •
edited

Using the GET method to perform EDS searches can fail when facet values are very long; this PR is intended to switch to POST for more robust behavior (while retaining GET as a configurable option for troubleshooting purposes).

TODO

  • Get basic functionality working
  • Implement missing filter / limiter functionality
  • Refine filter/limiter logic to handle multiple values better and to do proper unescaping
  • Consider making GET/POST behavior configurable in EDS.ini

@demiankatz demiankatz merged commit 994856c into vufind-org:master Jun 2, 2020
@demiankatz demiankatz changed the title Use POST instead of GET for EDS searches Configurable HTTP method for EDS search calls Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@demiankatz