Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GET instead of POST for limit control. #1727

Merged
merged 2 commits into from Oct 28, 2020

Conversation

demiankatz
Copy link
Member

  • Creates cleaner browser history (no back button problems, etc.).

- Creates cleaner browser history (no back button problems, etc.).
@demiankatz
Copy link
Member Author

It was brought to my attention that the "sort" form uses GET but the "limit" form uses POST. I can't think of any good reason to use POST instead of GET, so I have adjusted the template. @EreMaijala / @crhallberg, any concerns? Anything I'm not thinking of?

@EreMaijala
Copy link
Contributor

EreMaijala commented Sep 24, 2020

@demiankatz No problems that I can think of right away.

There's a bit of a discrepancy between handling of different parameters, though, as far as I can see: while limit and sort use the default values if not specified in the url, view does not. I suppose that's intentional so that a chosen view always sticks, but if you start a fresh session, make a search, change view and go back in history, the newly chosen view still sticks, while any changes to limit and sort would revert to the default values.

@demiankatz
Copy link
Member Author

Thanks, @EreMaijala. And yes, the view inconsistency is probably intentional, though that's not to say it couldn't be revisited if it's causing problems for anyone.

@demiankatz demiankatz merged commit c34074b into vufind-org:dev Oct 28, 2020
@demiankatz demiankatz removed the request for review from EreMaijala February 15, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants