Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show More Facets in Lightbox #678

Merged
merged 100 commits into from Jun 3, 2016

Conversation

Projects
None yet
2 participants
@crhallberg
Copy link
Contributor

commented Apr 12, 2016

Started with Chelsea (@ChelseaL) from Swarthmore.

  • Summon bug
  • Test with building: for stability
  • getPartialFacetList
  • Convert facetListAction to getPartialFacetList
  • Test compatibility with OR and NOT facet settings
  • Revise configuration functionality to match dev call discussion (second button)

@crhallberg crhallberg self-assigned this Apr 12, 2016

crhallberg and others added some commits Apr 12, 2016

Merge branch 'master' into facets-modal
Conflicts:
	themes/bootstrap3/templates/Recommend/SideFacets.phtml
@demiankatz

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

Just tried this out on my test server, and my "author" facet yields a generic error message in the pop-up. I'm guessing this may be a timeout or other limit related to the large number of values in that field. We may need some form of pagination. Pagination might also be nice for cosmetic reasons; the lightbox is a bit unwieldy with large numbers of values in it.

@demiankatz

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

Another problem: the Summon implementation is not fully fleshed out. The "Summon/FacetList" route definition is missing from module.config.php, and for some reason this causes a fatal error in the Summon search results even though showMoreInLightbox is not defined in Summon.ini and thus should be off by default. If I do define the route, I end up with a weird behavior where clicking on the "more" under a facet first expands the facet group and then forwards me to a full-page version of the Summon/FacetList route, which itself displays a white screen of death... so apparently this is broken on several levels. :-)

@demiankatz

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

Note: the problem of getting redirected to the FacetList action when showMoreInLightbox is turned off in facets.ini also affects the main Solr results, so that's a broader bug.

crhallberg and others added some commits May 26, 2016

Merge branch 'master' into facets-modal
Conflicts:
	themes/bootprint3/css/compiled.css
	themes/bootstrap3/css/compiled.css
@demiankatz

This comment has been minimized.

Copy link
Member

commented Jun 1, 2016

The latest round of questions/comments:

  1. Would ($showMoreInLightbox && $showMoreInLightbox !== 'more') be a safer condition than $showMoreInLightbox === '1'? I'm not sure that the .ini parser is always going to give you a string of '1' for every possible variation of a "true" configuration that a user might input.
  2. If we want the 'more' setting to be a default behavior, we should make sure it gets set when the setting is commented out in the .ini file (I don't think that's happening right now).

I can work on either or both of these things if you like... just let me know. Currently switching gears to look at a bug report that just came in.

@crhallberg

This comment has been minimized.

Copy link
Contributor Author

commented Jun 1, 2016

  1. I tested around various values and they all seemed to work but I am must more comfortable with this logic. Done.
  2. Done.

crhallberg and others added some commits Jun 1, 2016

Add nofollow attributes to more/see all links.
- Search engines don't really need to crawl deeply into facet lists; this will only produce server load and user confusion.

@demiankatz demiankatz merged commit 4678445 into vufind-org:master Jun 3, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

olli-gold pushed a commit to tubhh/vufind that referenced this pull request Aug 24, 2016

Oliver Goldschmidt
refs vufind-org#678: Articles-tab: display year of publication only, …
…even if a complete publication date is set

olli-gold pushed a commit to tubhh/vufind that referenced this pull request Aug 24, 2016

@crhallberg crhallberg deleted the crhallberg:facets-modal branch Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.