Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader codegen always treats descriptors as readonly #1264

Open
Xenopathic opened this issue Oct 28, 2019 · 1 comment

Comments

@Xenopathic
Copy link

@Xenopathic Xenopathic commented Oct 28, 2019

Vulkano 0.14

I have a GLSL file with some readonly descriptors and some not, however the code generated by vulkano-shaders marks all of the descriptors as readonly. This has knock-on effects like the pipeline barrier code not working, since it looks for buffers that are not readonly in order to generate barriers in the right places.

It seems like vulkano-shaders always considers descriptors to structs (and by rule induction, buffers too) as readonly, which doesn't seem correct: https://github.com/vulkano-rs/vulkano/blob/master/vulkano-shaders/src/descriptor_sets.rs#L203

@Ziqul

This comment has been minimized.

Copy link

@Ziqul Ziqul commented Nov 19, 2019

Any recepie for workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.