Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch-Size as property #202

Open
flashpixx opened this issue May 14, 2024 · 1 comment · May be fixed by #204
Open

Batch-Size as property #202

flashpixx opened this issue May 14, 2024 · 1 comment · May be fixed by #204
Labels
bug Something isn't working

Comments

@flashpixx
Copy link

flashpixx commented May 14, 2024

What did you do?

Integrate the Fetcher and Search option into my program by using the SQLite database. I would like to use go-exploitdb as library in an own program with SQLite database for offline usage

What did you expect to happen?

I get an error batch-size option is not set properly

Steps to reproduce the behaviour

See the line the batch-size is set by an environment variable / argument flag and not by a property of the RDBDriver struct.

Solution Suggestion

Add to the Option struct a property batchSize: uint and use it instead of the viper.GetInt("batch-size") call and it would be nice to provide a default value.

Configuration:

  • Go version (go version): 1.22
  • go-exploitdb environment: Version 0.4.6
@flashpixx flashpixx added the bug Something isn't working label May 14, 2024
@flashpixx flashpixx linked a pull request May 16, 2024 that will close this issue
6 tasks
@flashpixx
Copy link
Author

add PR to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant