Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] FDGA: Crashes when token_map_path file has wrong format #75

Closed
HugoSoszynski opened this issue Oct 2, 2019 · 0 comments
Closed
Assignees
Labels
bug Something isn't working pending Issue have a pull request waiting for review technical
Milestone

Comments

@HugoSoszynski
Copy link
Contributor

Describe the bug
When the file contained in the "token_map_path" field of the config is not properly formatted the filter crashes without logging.

Platform (please complete the following information):

  • OS (version): FreeBSD (12.0)
  • Darwin version: 1.0

To Reproduce
Steps to reproduce the behavior:

  1. Generate a random file
  2. Set the field "token_map_path" to ths file
  3. Start fdga

Expected behavior
Log a CRITICAL error with the proper message and quit gracefully.

Additional context
Hint: Look around line 140-143 of fdga/Generator.cpp

@HugoSoszynski HugoSoszynski added bug Something isn't working technical labels Oct 2, 2019
@HugoSoszynski HugoSoszynski added this to the Version 1.0.2 milestone Oct 7, 2019
@NS4nti NS4nti self-assigned this Oct 17, 2019
@NS4nti NS4nti mentioned this issue Oct 17, 2019
8 tasks
@NS4nti NS4nti added the pending Issue have a pull request waiting for review label Oct 29, 2019
@NS4nti NS4nti closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending Issue have a pull request waiting for review technical
Projects
None yet
Development

No branches or pull requests

2 participants