Fixes and normalizations on the MIDI modules #119

Merged
merged 3 commits into from Mar 31, 2013

Projects

None yet

2 participants

@mhusinsky
Contributor

Following issues were fixed:

  • Inconsistencies in channel addressing
    • Some nodes expected channel numbers from 1-16 in Channel IOBox, some from 0-15. Now all expect 0-15 (as stated already in the helpfile)
    • Incorrect channel mapping and issues with resetting pins: Setting Channel 15 to some of the nodes would result in incorrect sending on channel 0. Reason for that was the use of the Map(Value) node with wrapping. Also, resetting pins/nodes would result in improper channel numbers (0.5). -> Replaced Map with Frac and Mod. Nodes/Pins behave as expected now.
  • Inconsistencies with pins
    • some modules had an "Enabled" and "MidiOutputPort" pin, some did not. Now all have them.
  • MidiControllerOut: Limited Controller number to values from 0 to 119 as defined in Midi specs ( http://www.midi.org/techspecs/midimessages.php )
@mhusinsky mhusinsky Fixes and normalizations on the MIDI modules:
Following issues were fixed:
* Inconsistencies in channel addressing
** Some nodes expected channel numbers from 1-16 in Channel IOBox, some from 0-15. Now all expect 0-15 (as stated already in the helpfile)
** Incorrect channel mapping and issues with resetting pins: Setting Channel 15 to some of the nodes would result in incorrect sending on channel 0. Reason for that was the use of the Map(Value) node with wrapping. Also, resetting pins/nodes would result in improper channel numbers (0.5). -> Replaced Map with Frac and Mod. Nodes/Pins behave as expected now.
* Inconsistencies with pins
**  some modules had an "Enabled" and "MidiOutputPort" pin, some did not. Now all have them.
* MidiControllerOut: Limited Controller number to values from 0 to 119 as defined in Midi specs ( http://www.midi.org/techspecs/midimessages.php )
0049bec
@tebjan tebjan was assigned Mar 15, 2013
@tebjan tebjan merged commit 9d3d0d7 into vvvv:develop Mar 31, 2013
@tebjan
Member
tebjan commented Mar 31, 2013

thank you, great update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment