Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

FontAwesome icon upgrade to 2.0 #62

Merged
merged 3 commits into from Sep 5, 2012

Conversation

Projects
None yet
Contributor

toao commented Jun 6, 2012

Upgraded the font-files and the .icon-css-classes to support the 70 new icons from fontawesome 2.0
Mainly copied the data from the main fontawesome repo. Left out the ie7 css-files for the moment.

Contributor

matenia commented Jun 7, 2012

+1 for this and thanks.
/me cherry-picks you!

dfross commented Jun 7, 2012

+1

+1

+1

requnix commented Jun 21, 2012

+1

+1000

marcusg commented Jun 26, 2012

+1

vr-pair commented Jul 6, 2012

+1

@ghost

ghost commented Jul 6, 2012

+1

@vwall are you still maintaining this?

@tmaier tmaier referenced this pull request Jul 9, 2012

Closed

Remove Font Awesome #67

+1, why hasn't this been merged in yet?

Contributor

kristianmandrup commented Aug 30, 2012

Hmm, yeah... why have the font-awesome in this repo. Not really related I would think?
Would make more sense to make a separate fontawesome-rails gem, no?

@kristianmandrup I didn't mean #67.... like the others here, I love that Font Awesome comes bundled and ready-to-go (no dependency hell!). I just want to know why this pull request is in limbo -- @vwall, are you planning to merge or close it?

Contributor

kristianmandrup commented Aug 30, 2012

Well, if anyone wants a decoupled version of font-awesome 2.0, here is a new gem I just created: https://github.com/kristianmandrup/font_awesome-sass-rails

Needs testing in the wild... but at least it is 2.0 (taken from Font-Awesome-More) and should be ready to go.

PS: Discovered there was also a https://github.com/bokmann/font-awesome-rails gem, but it only comes with css

@vwall vwall added a commit that referenced this pull request Sep 5, 2012

@vwall vwall Merge pull request #62 from toao/master
FontAwesome icon upgrade to 2.0
869202a

@vwall vwall merged commit 869202a into vwall:master Sep 5, 2012

Awesome, @vwall. Glad to see you back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment