Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PhantomJS #44

Merged
merged 1 commit into from May 31, 2019

Conversation

Projects
None yet
2 participants
@pimterry
Copy link
Contributor

commented May 31, 2019

This fixes #33 (working towards #43).

I've removed every phantom reference, and any unused code that that left. It's hard to tell if there are any special cases or logic elsewhere that are now irrelevant, but I can't see anything obvious.

@vweevers

This comment has been minimized.

Copy link
Owner

commented May 31, 2019

It's hard to tell if there are any special cases or logic elsewhere that are now irrelevant, but I can't see anything obvious.

There's some "pre-hook" logic that can probably be removed, but that's only internals, so I'll open an new issue to clean that up later.

@vweevers
Copy link
Owner

left a comment

I'm glad to get rid of all that nasty code! :)

@vweevers vweevers merged commit ca6448d into vweevers:master May 31, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@pimterry pimterry deleted the pimterry:drop-phantomjs branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.