Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve detection of Chrome channel variants #61
Working towards a fix for #55, based on the comments there. This implements the suggested change, and improves the detection in general, especially for beta & dev channels.
That said, while this is an improvement, I haven't reproduce the reported issues, so I can't confirm that the ChromeHTML key is the main culprit.
I did manage to hit issues on this test environment due to the default 'stable' assumption from
I'm a bit suspicious of the bitness check in
Let's remove that line altogether (L48):
We already have the
I've merged the change to drop bitness, and we're all good now I think.
Updated debug output for reference: