Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid throwing errors if the registry is not readable #65

Merged
merged 1 commit into from Nov 22, 2019

Conversation

@pimterry
Copy link
Contributor

pimterry commented Nov 21, 2019

Previously this could happen if the user did not have access to the given key (#64), and probably in other rare cases.

I can't reproduce these real registry errors myself, but I've tested this by inserting a throw new Error() into enumerateValues in registry-js.

Given that error, without this change node cli.js --debug crashes. With this change, it happily reports all non-registry info.

Previously this could happen if the user did not have access
to the given key, and probably in various other rare cases.
@vweevers vweevers merged commit 3cc4100 into vweevers:master Nov 22, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@pimterry pimterry deleted the pimterry:safe-registry-lookups branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.