Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable prebuilding for Node 12 #4

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@pimterry
Copy link
Contributor

commented May 31, 2019

As part of working towards vweevers/win-detect-browsers#43.

Haven't tested this properly, but it seems pretty clear cut.

@vweevers

This comment has been minimized.

Copy link
Owner

commented May 31, 2019

Build failed but upgrading nan might fix that. Lemme take a look at #3, then you can rebase this and retry.

Edit: that wasn't enough but I got it to work in node 12 with a few changes. Broke node 10 though 😄

@pimterry pimterry force-pushed the pimterry:patch-1 branch from 516470b to 58d998e May 31, 2019

@vweevers

This comment has been minimized.

Copy link
Owner

commented May 31, 2019

@pimterry I'll make a new PR with fixes for node 12 shortly, please hold

@pimterry

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

Ok, sure, I'll wait

@vweevers vweevers referenced this pull request May 31, 2019

Merged

Fix node 12 #5

@vweevers vweevers closed this May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.