Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conntrack-sync: T4237: Fix checks for listen-address list to str #1218

Merged
merged 1 commit into from Feb 11, 2022

Conversation

sever-sever
Copy link
Member

Change Summary

Verify section conntrack_sync.py function 'is_addr_assigned'
should checks address as a string, not as a list

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

conntrack-sync

Proposed changes

How to test

Expected commit without errors

set interfaces ethernet eth0 address '192.168.0.50/24'
set high-availability vrrp group FOO interface 'eth0'
set high-availability vrrp group FOO virtual-address '192.168.0.254/24'
set high-availability vrrp group FOO vrid '10'
set high-availability vrrp sync-group SG member 'FOO'
set service conntrack-sync failover-mechanism vrrp sync-group 'SG'
set service conntrack-sync interface eth0
set service conntrack-sync listen-address '192.168.0.50'

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Verify section conntrack_sync.py funciton 'is_addr_assigned'
should checks address as string not as list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants