Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configtree: T4961: improve error reporting of function copy #1789

Merged
merged 1 commit into from Jan 28, 2023

Conversation

jestabro
Copy link
Contributor

@jestabro jestabro commented Jan 27, 2023

Change Summary

The function copy in vyos.configtree does not recursively create intermediary nodes of the target path; only the last node of the path is created. However, the error was not being caught/reported in case of a non-existent node. Corrected error reporting is provided in the PR's:
vyos/vyos1x-config#12 (merged)
vyos/libvyosconfig#6 (merged)

and is passed to ConfigTreeError in this PR.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this Jan 27, 2023
@c-po c-po requested review from a team, dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team January 27, 2023 20:01
@jestabro jestabro requested review from dmbaturin, c-po and sever-sever and removed request for a team January 27, 2023 20:01
@c-po c-po merged commit 248d4ed into vyos:current Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants