Skip to content

/vyper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIP: Remove sha3 alias #1328

Closed
jacqueswww opened this issue Mar 6, 2019 · 3 comments
Closed

VIP: Remove sha3 alias #1328

jacqueswww opened this issue Mar 6, 2019 · 3 comments
Labels
Approved

Comments

@jacqueswww
Copy link
Collaborator

@jacqueswww jacqueswww commented Mar 6, 2019

Simple Summary

Remove the sha3 function, in favour of only using keccak256

Abstract

Remove the sha3 function, in favour of only using keccak256.

Motivation

keecak256 and sha3 are currently aliases of each, however talking in general and standardised terms keccak256 is not the same function as sha3, therefore the proposal to remove sha3 completely to avoid confusion.

Specification

A call to sha3:

sha3(val)

Will throw a compiler error, with a message "sha3 function has been deprecated in favour of keccak256".

Backwards Compatibility

This change is not backwards compatible.

Dependencies

None

Copyright

Copyright and related rights waived via CC0
@jacqueswww jacqueswww mentioned this issue Mar 10, 2019
Closed
@jacqueswww jacqueswww added the Approved label Mar 11, 2019
@jakerockland

This comment has been minimized.

Sign in to view
Copy link
Contributor

@jakerockland jakerockland commented Jun 26, 2019

@jacqueswww can I go ahead and implement this one?
@fubuloubu fubuloubu changed the title Remove sha3 alias VIP: Remove sha3 alias Jun 26, 2019
jakerockland added a commit to jakerockland/vyper that referenced this issue Jun 27, 2019
@jakerockland
Remove sha3 alias, VIP vyperlang#1328
d7a718f
@jakerockland jakerockland mentioned this issue Jun 27, 2019
Merged
@jakerockland

This comment has been minimized.

Sign in to view
Copy link
Contributor

@jakerockland jakerockland commented Jun 27, 2019

@jacqueswww I got restless 😂 🙃
@fubuloubu fubuloubu removed the discussion label Aug 8, 2019
@fubuloubu

This comment has been minimized.

Sign in to view
Copy link
Member

@fubuloubu fubuloubu commented Aug 8, 2019

Closed by #1503
@fubuloubu fubuloubu closed this Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Approved
Projects
None yet
Milestone
No milestone
3 participants
@jacqueswww @jakerockland @fubuloubu
You can’t perform that action at this time.