feat: arithmetic for new int types #2843
Conversation
|
This pull request introduces 3 alerts when merging ea16bf0 into df2da62 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 8fef032 into df2da62 - view on LGTM.com new alerts:
|
charles-cooper
force-pushed
the
refactor_arithmetic
branch
from
8fef032
to
2324bcf
Compare
|
This pull request introduces 2 alerts when merging 2324bcf into 3cbdf35 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #2843 +/- ##
==========================================
+ Coverage 88.17% 88.30% +0.13%
==========================================
Files 95 96 +1
Lines 10584 10611 +27
Branches 2534 2531 -3
==========================================
+ Hits 9332 9370 +38
+ Misses 792 787 -5
+ Partials 460 454 -6
Continue to review full report at Codecov.
|
charles-cooper
force-pushed
the
refactor_arithmetic
branch
3 times, most recently
from
287b82d
to
2d49d2f
Compare
|
This pull request introduces 2 alerts when merging 2d49d2f into 3cbdf35 - view on LGTM.com new alerts:
|
charles-cooper
force-pushed
the
refactor_arithmetic
branch
from
391aae1
to
379fac9
Compare
|
This pull request introduces 6 alerts when merging 379fac9 into 3cbdf35 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging ac8454d into 3cbdf35 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging a338657 into 31e2b4e - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 4d32b08 into 18b9083 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging ef11232 into 18b9083 - view on LGTM.com new alerts:
|
charles-cooper
force-pushed
the
refactor_arithmetic
branch
from
ef11232
to
c29128f
Compare
|
This pull request introduces 3 alerts when merging c29128f into 18b9083 - view on LGTM.com new alerts:
|
charles-cooper
changed the title
| xs = special_cases.copy() | ||
| ys = special_cases.copy() | ||
| NUM_CASES = 10 | ||
| # poor man's fuzzing - hypothesis doesn't make it easy |
|
it's a bit odd, tox reports that no tests were collected for group 45, but when i run that group directly via pytest, it runs 316 tests. |
the (default) duration_based_chunks splitting algorithm in pytest-split resulted in a 0-size chunk getting allocated to the final group.
What I did
implement #2786, fixes #2840
How I did it
refactor arithmetic to be generic over numeric types
How to verify it
check arithmetic tests, they now test over all types and "interesting" values. also added more interesting decimal tests.
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture