Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix private underflow #1470

Merged
merged 7 commits into from Jun 6, 2019
Merged

Conversation

@charles-cooper
Copy link
Collaborator

charles-cooper commented Jun 5, 2019

What I did

Fix #1463

How I did it

The dynamic section copier skipped null elements in case there was a difference between len(array) and maxlen(array) since elements past-the-end of memory are null. However, that could fail if the array length was nonzero but it had null elements. This fixes the dynamic section copier by explicitly using the length specified in the ABI encoding for byte arrays.

How to verify it

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@jacqueswww

This comment has been minimized.

Copy link
Collaborator

jacqueswww commented Jun 5, 2019

Appropriate 'cute' image, figuring this out was a challenge indeed! 👅

@jacqueswww

This comment has been minimized.

Copy link
Collaborator

jacqueswww commented Jun 5, 2019

Great stuff!

@jacqueswww jacqueswww merged commit a072741 into vyperlang:master Jun 6, 2019
3 checks passed
3 checks passed
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
@charles-cooper charles-cooper deleted the charles-cooper:fix_private_underflow branch Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.