Reduce contract code size by wrapping clamping of args into a loop

[siraben]

What I did

Reduced contract code size due to codegen of run-time type checking of list elements.

How I did it

Changed make_arg_clamper to generate an LLL loop instead of recursing over the list elements, when there are more than 5 elements in the list.

All the tests pass.

How to verify it

Compile the following contract.

struct Animal:
    Name: uint256
    Exists: int128

COLLECTION_SIZE: constant(uint256) = 1000

contractOwner: address
daddy: address
collection: map(address, Animal)

count: int128

@private
@constant
def isZookeeper(sender: address) -> bool:
    return sender == self.contractOwner or sender == self.daddy

@public
def addToCollection(animals: address[COLLECTION_SIZE]):
    assert self.isZookeeper(msg.sender)

    for animal in animals:
        if animal == ZERO_ADDRESS: break

        if self.collection[animal].Exists == 0:
            self.count += 1
            self.collection[animal].Exists = self.count

@public
def __init__(myDaddy: address):
    self.daddy = myDaddy

Old code size (bytes): 55340
New code size (bytes): 17474
This PR combined with #1486 reduces the code size down to a whopping 1644 bytes

Cute Animal Picture

[charles-cooper]

when are datapos and mempos lists?

[siraben]

When we have a list of lists! This was revealed to me in one of the test cases.

[charles-cooper]

which test case?

[jacqueswww]

@siraben I think you should just use get_size_of_type(typ) here instead this will support above cases as well.

[jacqueswww]

LGTM. Just one change in the if statement.

[jacqueswww]

@siraben I think you should just use get_size_of_type(typ) here instead this will support above cases as well.

[jacqueswww]

Merging now, will add get_size_of_type separately.