Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic type conversions from `address` type #1524

Merged
merged 9 commits into from Jul 16, 2019

Conversation

@jakerockland
Copy link
Contributor

jakerockland commented Jul 10, 2019

What I did

Implements missing conversions from address to other basic types, as specified in #1093 — note conversion from address to bytes type has yet to be implemented, but was holding off on this for this specific PR as there are also a handful of other conversions to bytes type that need to be implemented still and feel that could just be its own PR.

How I did it

Updated convert.py to support new conversions.

How to verify it

Run the tests make test

Description for the changelog

Add missing conversions from address type to other basic types

Cute Animal Picture

image

@jakerockland jakerockland changed the title Conversions from address Basic type conversions from `address` type Jul 11, 2019
Copy link
Collaborator

jacqueswww left a comment

LGTM, just a minor note.

[
'signextend',
15,
['and', in_arg, 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF],

This comment has been minimized.

Copy link
@jacqueswww

jacqueswww Jul 15, 2019

Collaborator

I think using SizeLimits here would be cleaner?

This comment has been minimized.

Copy link
@jacqueswww

jacqueswww Jul 15, 2019

Collaborator

SizeLimits.ADDRSIZE specifically :)

This comment has been minimized.

Copy link
@jakerockland

jakerockland Jul 15, 2019

Author Contributor

@jacqueswww ah good call! 😅 I had overlooked that that constant existed — will make this change tonight.

@jakerockland

This comment has been minimized.

Copy link
Contributor Author

jakerockland commented Jul 16, 2019

@jacqueswww fixed!

@jacqueswww jacqueswww merged commit 95fa21a into vyperlang:master Jul 16, 2019
3 checks passed
3 checks passed
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.