Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upBasic type conversions from `address` type #1524
Merged
Conversation
jakerockland
changed the title
|
LGTM, just a minor note. |
vyper/types/convert.py
Outdated
| [ | ||
| 'signextend', | ||
| 15, | ||
| ['and', in_arg, 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF], |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jakerockland
Jul 15, 2019
Author
Contributor
@jacqueswww ah good call!
This comment has been minimized.
This comment has been minimized.
|
@jacqueswww fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jakerockland commentedJul 10, 2019
•
edited
What I did
Implements missing conversions from
addressto other basic types, as specified in #1093 — note conversion fromaddresstobytestype has yet to be implemented, but was holding off on this for this specific PR as there are also a handful of other conversions tobytestype that need to be implemented still and feel that could just be its own PR.How I did it
Updated
convert.pyto support new conversions.How to verify it
Run the tests
make testDescription for the changelog
Add missing conversions from
addresstype to other basic typesCute Animal Picture