Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Zero pad from calldata #1605
What I did
How I did it
CALLDATACOPY writes zero bytes into memory when the location in calldata is >= calldatasize.
How to verify it
Description for the changelog
Cute Animal Picture
The semantics of calldatacopy is that copying data from past-the-end writes zero bytes to memory. So we can avoid the loop, making the code more gas-efficient and easier to reason about.
maxlen was confusingly named. maxlen referred to the static size of the entire packed log. instead, the maxlen of the current item should be passed to zero_pad.
It's a red herring. byte arrays should always be padded to the runtime length and not maxlen.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.