Fix termination condition in zero_pad #1611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlen was confusingly named. maxlen referred to the static size of the entire packed log. instead, the maxlen of the current item should be passed to zero_pad.
bytearrays are padded to ceil32(runtime_len), not ceil32(maxlen).
charles-cooper
changed the title
|
This fixes the issues that I reported, and will unblock the deposit contract verification. |
Merged
|
LGTM, @charles-cooper anyway that we could've picked this up in a test? |
jacqueswww
approved these changes
Sep 24, 2019
|
@jacqueswww yeah maybe, I think if there was data in the next cell whose first byte (BE) was nonzero then it would have been corrupted. |
This was referenced Sep 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What I did
Fix #1599, #1610
How I did it
See mentioned issues for discussion
How to verify it
Description for the changelog
Fix zero padding conditions in ABI encoder
Cute Animal Picture