Skip to content

/vyper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix termination condition in zero_pad #1611

Merged
merged 4 commits into from Sep 24, 2019
Merged

Fix termination condition in zero_pad #1611

merged 4 commits into from Sep 24, 2019

Conversation

@charles-cooper
Copy link
Collaborator

charles-cooper commented Sep 10, 2019 •
edited

What I did

Fix #1599, #1610

How I did it

See mentioned issues for discussion

How to verify it

Description for the changelog

Fix zero padding conditions in ABI encoder

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->
@charles-cooper
Fix termination condition in zero_pad
Loading status checks…
77c910e
@charles-cooper
Fix maxlen passed to zero_pad in pack_args_by_32
Loading status checks…
033d7df 
maxlen was confusingly named. maxlen referred to the static size of the
entire packed log. instead, the maxlen of the current item should be
passed to zero_pad.
@charles-cooper
Fix termination condition for zero_pad again
Loading status checks…
5469fae 
bytearrays are padded to ceil32(runtime_len), not ceil32(maxlen).
@charles-cooper
Add a note to zero_pad
Loading status checks…
9a46479
@charles-cooper charles-cooper changed the title WIP Fix termination condition in zero_pad Fix termination condition in zero_pad Sep 16, 2019
@fubuloubu fubuloubu mentioned this pull request Sep 16, 2019
Closed
@daejunpark

This comment has been minimized.

Sign in to view
Copy link
Contributor

daejunpark commented Sep 17, 2019

This fixes the issues that I reported, and will unblock the deposit contract verification.
@djrtwo djrtwo requested a review from davesque Sep 17, 2019
@charles-cooper charles-cooper mentioned this pull request Sep 21, 2019
Merged
@jacqueswww

This comment has been minimized.

Sign in to view
Copy link
Collaborator

jacqueswww commented Sep 24, 2019

LGTM, @charles-cooper anyway that we could've picked this up in a test?
@jacqueswww
jacqueswww approved these changes Sep 24, 2019
View changes
@charles-cooper

This comment has been minimized.

Sign in to view
Copy link
Collaborator Author

charles-cooper commented Sep 24, 2019

@jacqueswww yeah maybe, I think if there was data in the next cell whose first byte (BE) was nonzero then it would have been corrupted.
@charles-cooper charles-cooper merged commit 32ce6c9 into vyperlang:master Sep 24, 2019
3 checks passed
3 checks passed
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
This was referenced Sep 25, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacqueswww jacqueswww

@davesque davesque

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@charles-cooper @daejunpark @jacqueswww
You can’t perform that action at this time.