Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 1636 unary negation bug #1638

Merged
merged 5 commits into from Oct 18, 2019
Merged

Conversation

fubuloubu
Copy link
Member

@fubuloubu fubuloubu commented Oct 17, 2019

What I did

Fixed: #1636

How I did it

  • Reject Unary negation on unsigned integers
  • Clamped that unary negation must be strictly greater than minimum value for signed integer

Description for the changelog

Fixed unary negation bug

Cute Animal Picture

slow morning

@fubuloubu fubuloubu changed the title 1636 usub bug Fixed 1636 unary negation bug Oct 17, 2019
vyper/parser/expr.py Outdated Show resolved Hide resolved
@fubuloubu fubuloubu requested a review from charles-cooper Oct 18, 2019
Copy link
Collaborator

@charles-cooper charles-cooper left a comment

Thanks, LGTM

@fubuloubu fubuloubu merged commit 33ad0b5 into vyperlang:master Oct 18, 2019
3 checks passed
@fubuloubu fubuloubu deleted the 1636-usub-bug branch Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants