Force parse_body to be zerovalent #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seq will issue a pop after every univalent statement but the last one. However, if and for statements should have zerovalent bodies, so this forces even the last statement to get a pop if it is univalent.
charles-cooper
force-pushed
the
fix_body_valency
branch
from
95350f4
to
e7945d8
Compare
issues 1511 and 1620
pass could mean pop
charles-cooper
force-pushed
the
fix_body_valency
branch
from
e7945d8
to
cbd7ded
Compare
charles-cooper
changed the title
jacqueswww
approved these changes
Nov 7, 2019
|
Thanks Charles! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix #1511 and #1620
How I did it
Seq will issue a pop after every univalent statement but the last one.
However, if and for statements should have zerovalent bodies. This PR
forces even the last statement to get a pop if it is univalent.
How to verify it
See new tests
Description for the changelog
Fix stack valency issues in if and for statements.
Cute Animal Picture