Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force parse_body to be zerovalent #1665

Merged
merged 4 commits into from Nov 7, 2019

Conversation

@charles-cooper
Copy link
Collaborator

charles-cooper commented Oct 29, 2019

What I did

Fix #1511 and #1620

How I did it

Seq will issue a pop after every univalent statement but the last one.
However, if and for statements should have zerovalent bodies. This PR
forces even the last statement to get a pop if it is univalent.

How to verify it

See new tests

Description for the changelog

Fix stack valency issues in if and for statements.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper requested a review from jacqueswww Oct 29, 2019
Seq will issue a pop after every univalent statement but the last one.
However, if and for statements should have zerovalent bodies, so this
forces even the last statement to get a pop if it is univalent.
@charles-cooper charles-cooper force-pushed the charles-cooper:fix_body_valency branch from 95350f4 to e7945d8 Oct 30, 2019
pass could mean pop
@charles-cooper charles-cooper force-pushed the charles-cooper:fix_body_valency branch from e7945d8 to cbd7ded Oct 30, 2019
@charles-cooper charles-cooper changed the title WIP Force parse_body to be zerovalent Force parse_body to be zerovalent Oct 31, 2019
@jacqueswww

This comment has been minimized.

Copy link
Collaborator

jacqueswww commented Nov 7, 2019

Thanks Charles!

Copy link
Contributor

iamdefinitelyahuman left a comment

👍

@charles-cooper charles-cooper merged commit 4666a87 into vyperlang:master Nov 7, 2019
3 checks passed
3 checks passed
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.