Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix off-by-one in list type checking #1673

Merged
merged 2 commits into from Nov 11, 2019

Conversation

@charles-cooper
Copy link
Collaborator

charles-cooper commented Oct 31, 2019

What I did

Fix off-by-one in list type checking

How I did it

The loop wanted to check if there were any elements in the output list yet, but the check should have been >= 1 instead of > 1

How to verify it

Description for the changelog

Fix off-by-one in check for homogeneous list element types.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper requested a review from jacqueswww Oct 31, 2019
Copy link
Member

fubuloubu left a comment

It would be great if this off by one error had a test case

@fubuloubu fubuloubu merged commit da3e657 into vyperlang:master Nov 11, 2019
3 checks passed
3 checks passed
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.