Add support for Python3.8#1678
Conversation
iamdefinitelyahuman
force-pushed
the
py38-ast
branch
from
ce61beb to
e78a1ad
Compare
|
Huh, fuzzing actually caught something this time lol |
|
Failing test should be fixed by #1679 |
|
@iamdefinitelyahuman rebase master |
|
I'd like to merge #1657 first and rebase on that to ensure we're playing with all the latest toys |
iamdefinitelyahuman
force-pushed
the
py38-ast
branch
from
7d44c61 to
aab7e5f
Compare
| elif isinstance(node, python_ast.NameConstant): | ||
| class_name = "NameConstant" | ||
| else: | ||
| class_name = node.__class__.__name__ |
There was a problem hiding this comment.
Not sure I understand the fix here, as far as I can tell all these types are replaced by Constant(value=) now, doesn't that mean we have to translate each constant type and port over the value attribute (e.g. .s for Str and .n for number) ?
There was a problem hiding this comment.
And would that mean something the replacement step would have to map something like isinstance(node.value, str) => vyper_ast.Str(s=node.value) (if isinstance(node, python_ast.Constant).
There was a problem hiding this comment.
See new commits based on our discussion 👍
|
technically, cc @carver |
iamdefinitelyahuman
force-pushed
the
py38-ast
branch
4 times, most recently
from
24d5e4f to
cbefaa8
Compare
|
Spending some time on this today. |
|
Just released blake2b-py v0.1.3 that includes support for python 3.8. |
iamdefinitelyahuman
force-pushed
the
py38-ast
branch
from
cbefaa8 to
23013ac
Compare
5 participants
What I did
Add support for Python 3.8
How I did it
Constantpython AST type with deprecated type names when generating Vyper AST nodes.How to verify it
Run the tests
Description for the changelog
Cute Animal Picture