Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for Python3.8 #1678
Conversation
ce61beb
to
e78a1ad
This comment has been minimized.
This comment has been minimized.
Huh, fuzzing actually caught something this time lol |
This comment has been minimized.
This comment has been minimized.
Failing test should be fixed by #1679 |
This comment has been minimized.
This comment has been minimized.
@iamdefinitelyahuman rebase master |
This comment has been minimized.
This comment has been minimized.
I'd like to merge #1657 first and rebase on that to ensure we're playing with all the latest toys |
7d44c61
to
aab7e5f
else: | ||
class_name = node.__class__.__name__ |
This comment has been minimized.
This comment has been minimized.
jacqueswww
Nov 7, 2019
Collaborator
Not sure I understand the fix here, as far as I can tell all these types are replaced by Constant(value=) now, doesn't that mean we have to translate each constant type and port over the value attribute (e.g. .s
for Str and .n
for number) ?
This comment has been minimized.
This comment has been minimized.
jacqueswww
Nov 7, 2019
•
Collaborator
And would that mean something the replacement step would have to map something like isinstance(node.value, str)
=> vyper_ast.Str(s=node.value)
(if isinstance(node, python_ast.Constant).
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
technically, cc @carver |
24d5e4f
to
cbefaa8
This comment has been minimized.
This comment has been minimized.
carver
commented
Nov 7, 2019
This comment has been minimized.
This comment has been minimized.
Spending some time on this today. |
This comment has been minimized.
This comment has been minimized.
Just released blake2b-py v0.1.3 that includes support for python 3.8. |
cbefaa8
to
23013ac
iamdefinitelyahuman commentedNov 4, 2019
What I did
Add support for Python 3.8
How I did it
Constant
python AST type with deprecated type names when generating Vyper AST nodes.How to verify it
Run the tests
Description for the changelog
Cute Animal Picture