Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scientific notation an invalid literal declaration #1681

Merged
merged 3 commits into from Nov 12, 2019

Conversation

@fubuloubu
Copy link
Member

fubuloubu commented Nov 6, 2019

fixes: #1680

What I did

Raise InvalidLiteralException when scientific notation is used for a literal value (either for a constant, or in a method)

How I did it

WIP

How to verify it

Well, tests fail...

Description for the changelog

Added additional verification of literals to ensure scientific notation was not used (as Python interprets as a float)

Cute Animal Picture

cute birds

@fubuloubu fubuloubu changed the title Make scientific notation an invalid literal declaration WIP Make scientific notation an invalid literal declaration Nov 7, 2019
@fubuloubu fubuloubu force-pushed the fubuloubu/1680-scientific-notation branch from 855dce2 to fd9f3d0 Nov 11, 2019
fixes: #1680
@fubuloubu fubuloubu marked this pull request as ready for review Nov 11, 2019
@fubuloubu fubuloubu changed the title WIP Make scientific notation an invalid literal declaration Make scientific notation an invalid literal declaration Nov 11, 2019
@fubuloubu fubuloubu requested a review from jacqueswww Nov 11, 2019
Copy link
Collaborator

jacqueswww left a comment

LGTM

@charles-cooper charles-cooper merged commit f8d9f84 into master Nov 12, 2019
4 checks passed
4 checks passed
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
ci/circleci: py38-core Your tests passed on CircleCI!
Details
@fubuloubu fubuloubu deleted the fubuloubu/1680-scientific-notation branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.