Only rewrite bytes32 when they are literals#1718
Merged
Merged
Conversation
charles-cooper
changed the title
charles-cooper
changed the title
The assignment should be disallowed if the RHS is not a literal.
charles-cooper
force-pushed
the
fix_bytes32_assign
branch
from
06ee82b to
74357fa
Compare
fubuloubu
approved these changes
Nov 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix #1717
How I did it
There is a rewrite rule but was only intended for literals.
How to verify it
Description for the changelog
Cute Animal Picture