Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only rewrite bytes32 when they are literals #1718

Merged
merged 3 commits into from Nov 12, 2019

Conversation

@charles-cooper
Copy link
Collaborator

charles-cooper commented Nov 11, 2019

What I did

Fix #1717

How I did it

There is a rewrite rule but was only intended for literals.

How to verify it

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper changed the title Only rewrite bytes32 when they are literals [WIP] Only rewrite bytes32 when they are literals Nov 11, 2019
@charles-cooper charles-cooper changed the title [WIP] Only rewrite bytes32 when they are literals Only rewrite bytes32 when they are literals Nov 11, 2019
@charles-cooper charles-cooper requested a review from jacqueswww Nov 11, 2019
The assignment should be disallowed if the RHS is not a literal.
@charles-cooper charles-cooper force-pushed the charles-cooper:fix_bytes32_assign branch from 06ee82b to 74357fa Nov 12, 2019
@charles-cooper charles-cooper requested a review from fubuloubu Nov 12, 2019
Copy link
Collaborator

jacqueswww left a comment

LGTM

@jacqueswww jacqueswww merged commit 6487cee into vyperlang:master Nov 12, 2019
4 checks passed
4 checks passed
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
ci/circleci: py38-core Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.