Add support raw_log data of bytes32.#1719
Merged
Merged
Conversation
jacqueswww
force-pushed
the
add_raw_log_bytes32
branch
from
8ae0bd8 to
c62bca5
Compare
charles-cooper
approved these changes
Nov 11, 2019
Member
charles-cooper
left a comment
charles-cooper
left a comment
There was a problem hiding this comment.
I was a little surprised we don't have convert(bytes32, <bytes[32-or-less]>). LGTM
fubuloubu
approved these changes
Nov 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I found this was quite necessary in some cases. Also we need to start supporting the other uint* types, keep seeing them in the wild, and then I have to do hacks like mining function signature + raw_log + raw_call.
How I did it
How to verify it
Description for the changelog
Cute Animal Picture