Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support raw_log data of bytes32. #1719

Merged
merged 3 commits into from Nov 12, 2019

Conversation

@jacqueswww
Copy link
Collaborator

jacqueswww commented Nov 11, 2019

What I did

I found this was quite necessary in some cases. Also we need to start supporting the other uint* types, keep seeing them in the wild, and then I have to do hacks like mining function signature + raw_log + raw_call.

How I did it

How to verify it

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

jacqueswww added 2 commits Nov 11, 2019
@jacqueswww jacqueswww requested review from fubuloubu and charles-cooper Nov 11, 2019
@jacqueswww jacqueswww force-pushed the jacqueswww:add_raw_log_bytes32 branch from 8ae0bd8 to c62bca5 Nov 11, 2019
Copy link
Collaborator

charles-cooper left a comment

I was a little surprised we don't have convert(bytes32, <bytes[32-or-less]>). LGTM

@jacqueswww jacqueswww merged commit dce7742 into vyperlang:master Nov 12, 2019
4 checks passed
4 checks passed
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
ci/circleci: py38-core Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.