Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment at EOF bugfix #1720

Merged
merged 1 commit into from Nov 12, 2019

Conversation

iamdefinitelyahuman
Copy link
Contributor

What I did

Fix #1701

How I did it

Append \n to all source code before compiling.

How to verify it

Run tests.

Cute Animal Picture

image

vyper/compiler.py Show resolved Hide resolved
Copy link
Collaborator

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vyper/compiler.py Show resolved Hide resolved
@fubuloubu fubuloubu merged commit da66acf into vyperlang:master Nov 12, 2019
@iamdefinitelyahuman iamdefinitelyahuman deleted the comment-eof-bugfix branch December 8, 2019 05:17
charles-cooper added a commit to charles-cooper/vyper that referenced this pull request Aug 9, 2021
The previous fix in vyperlang#1720 stopped working because the modified source
code was only being provided to some compilation steps (compile_codes)
but not others (get_interface_codes).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code that ends in a comment (with no newline) cannot be compiled
3 participants