Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix struct assignment order #1728

Merged
merged 3 commits into from Nov 28, 2019

Conversation

@charles-cooper
Copy link
Collaborator

charles-cooper commented Nov 14, 2019

What I did

Fix #1686

How I did it

fix the order of the RHS arguments in make_setter

How to verify it

cf. tests

Description for the changelog

Fix order of assignment statements in struct assignment

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper requested review from fubuloubu and jacqueswww Nov 14, 2019
@charles-cooper charles-cooper force-pushed the charles-cooper:fix_struct_typecheck branch 3 times, most recently from f6c0a39 to 7d67906 Nov 15, 2019
@charles-cooper charles-cooper changed the title WIP Fix struct assignment order Fix struct assignment order Nov 15, 2019
tests/parser/globals/test_setters.py Outdated Show resolved Hide resolved
tests/parser/globals/test_setters.py Outdated Show resolved Hide resolved
tests/parser/globals/test_setters.py Show resolved Hide resolved
@charles-cooper charles-cooper force-pushed the charles-cooper:fix_struct_typecheck branch from 7d67906 to 2a4dcda Nov 15, 2019
Copy link
Collaborator

jacqueswww left a comment

As part of this I think we should also apply mypy rules for the StructType / TupleLike types in types.py. So we can make sure we always pass a OrderedDict to the self.members :)

vyper/parser/expr.py Show resolved Hide resolved
@charles-cooper charles-cooper mentioned this pull request Nov 27, 2019
5 of 5 tasks complete
@fubuloubu

This comment has been minimized.

Copy link
Member

fubuloubu commented Nov 27, 2019

@jacqueswww 👍 and you can merge this

@charles-cooper charles-cooper force-pushed the charles-cooper:fix_struct_typecheck branch from 2a4dcda to 54fca05 Nov 28, 2019
@charles-cooper

This comment has been minimized.

Copy link
Collaborator Author

charles-cooper commented Nov 28, 2019

rebased off latest master to get the new CI to run

@charles-cooper charles-cooper merged commit c677e6f into vyperlang:master Nov 28, 2019
4 checks passed
4 checks passed
lint
Details
py36-core
Details
py37-core
Details
py38-core
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.