Fix struct assignment order#1728
Merged
charles-cooper merged 3 commits intovyperlang:masterfrom Nov 28, 2019
Merged
Conversation
charles-cooper
force-pushed
the
fix_struct_typecheck
branch
3 times, most recently
from
f6c0a39 to
7d67906
Compare
charles-cooper
changed the title
fubuloubu
approved these changes
Nov 15, 2019
charles-cooper
force-pushed
the
fix_struct_typecheck
branch
from
7d67906 to
2a4dcda
Compare
fubuloubu
approved these changes
Nov 15, 2019
jacqueswww
suggested changes
Nov 22, 2019
Contributor
jacqueswww
left a comment
jacqueswww
left a comment
There was a problem hiding this comment.
As part of this I think we should also apply mypy rules for the StructType / TupleLike types in types.py. So we can make sure we always pass a OrderedDict to the self.members :)
5 tasks
Contributor
|
@jacqueswww 👍 and you can merge this |
jacqueswww
approved these changes
Nov 28, 2019
charles-cooper
force-pushed
the
fix_struct_typecheck
branch
from
2a4dcda to
54fca05
Compare
Member
Author
|
rebased off latest master to get the new CI to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix #1686
How I did it
fix the order of the RHS arguments in make_setter
How to verify it
cf. tests
Description for the changelog
Fix order of assignment statements in struct assignment
Cute Animal Picture