Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary JS file #1770

Merged
merged 1 commit into from Dec 17, 2019
Merged

Removed unnecessary JS file #1770

merged 1 commit into from Dec 17, 2019

Conversation

@fubuloubu
Copy link
Member

fubuloubu commented Dec 15, 2019

Turns out, the signing logic is tested with Python in tests/examples/wallet/test_wallet.py, therefore the JS file is unnecessary

@fubuloubu fubuloubu changed the title refactor: Removed unnecessary JS file Removed unnecessary JS file Dec 15, 2019
@fubuloubu

This comment has been minimized.

Copy link
Member Author

fubuloubu commented Dec 15, 2019

Should remove lgtm JS analysis

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 15, 2019

Codecov Report

Merging #1770 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1770   +/-   ##
=======================================
  Coverage   86.32%   86.32%           
=======================================
  Files          51       51           
  Lines        5980     5980           
  Branches     1553     1553           
=======================================
  Hits         5162     5162           
  Misses        530      530           
  Partials      288      288

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a928138...0716436. Read the comment docs.

@fubuloubu fubuloubu merged commit 391b251 into master Dec 17, 2019
6 of 7 checks passed
6 of 7 checks passed
lint
Details
mypy
Details
py36-core
Details
py37-core
Details
py38-core
Details
LGTM analysis: JavaScript Analysis failed (could not build the merge commit)
Details
LGTM analysis: Python No code changes detected
Details
@fubuloubu fubuloubu deleted the fubuloubu/remove-javascript branch Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.