Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - Importing an interface that contains an 'implements' statement #1774

Merged

Conversation

@iamdefinitelyahuman
Copy link
Contributor

iamdefinitelyahuman commented Dec 19, 2019

The Issue

When importing a Vyper contract as an interface, a StructureException is raised if that file includes an implements statement.

How I fixed it

In vyper/signatures/interface.py, I modified extract_sigs to exclude AST nodes related to implements.

How to verify it

Run the tests. I added a new test case around this behavior.

Cute Animal Picture

image

@jacqueswww

This comment has been minimized.

Copy link
Collaborator

jacqueswww commented Dec 20, 2019

LGTM

@fubuloubu fubuloubu merged commit a83a781 into vyperlang:master Dec 22, 2019
7 checks passed
7 checks passed
lint
Details
mypy
Details
py36-core
Details
py37-core
Details
py38-core
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
@iamdefinitelyahuman iamdefinitelyahuman deleted the iamdefinitelyahuman:import-implements-bugfix branch Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.