Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow relative imports beyond one parent level #1784

Merged
merged 3 commits into from Jan 2, 2020

Conversation

iamdefinitelyahuman
Copy link
Contributor

@iamdefinitelyahuman iamdefinitelyahuman commented Dec 27, 2019

What I did

Allow relative imports beyond one parent level - fixes #1703

How I did it

  • vyper/signatures/interface.py - properly handle level > 2
  • vyper/cli - adjust checks for imports out of base folder

How to verify it

Run the tests. I added / modified a few test cases to make sure it works.

Cute Animal Picture

image

@fubuloubu
Copy link
Member

@fubuloubu fubuloubu commented Jan 2, 2020

Just rebase and g2g

@fubuloubu fubuloubu merged commit e0e09ad into vyperlang:master Jan 2, 2020
8 checks passed
@iamdefinitelyahuman iamdefinitelyahuman deleted the relative-import-fix branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants