Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minmax signing #1790

Merged
merged 2 commits into from Dec 28, 2019
Merged

Minmax signing #1790

merged 2 commits into from Dec 28, 2019

Conversation

@iamdefinitelyahuman
Copy link
Contributor

iamdefinitelyahuman commented Dec 28, 2019

What I did

Fix an error in min and max that caused incorrect evaluation with signed comparators - closes #1690

How I did it

Simplify / adjust logic in vyper/functions/functions.py - see code, it's fairly straightforward.

How to verify it

Run the tests. I added a new test case to check the example given in #1690.

Cute Animal Picture

image

@iamdefinitelyahuman iamdefinitelyahuman force-pushed the iamdefinitelyahuman:minmax-signing branch from ea00709 to 56c5626 Dec 28, 2019
@fubuloubu fubuloubu merged commit fb7ac96 into vyperlang:master Dec 28, 2019
7 checks passed
7 checks passed
lint
Details
mypy
Details
py36-core
Details
py37-core
Details
py38-core
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
@iamdefinitelyahuman iamdefinitelyahuman deleted the iamdefinitelyahuman:minmax-signing branch Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.