Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SHL/SHR for bitshifting #1796

Merged
merged 3 commits into from Jan 2, 2020

Conversation

@iamdefinitelyahuman
Copy link
Contributor

iamdefinitelyahuman commented Jan 2, 2020

What I did

  • use SHL/SHR for bitshifting when targeting >=constantinople EVM ruleset - closes #1268
  • bitshift bytecode optimizations

How I did it

functions.functions.shift: When _shift is a literal, do not include IF SLT 0 or resulting unreachable bytecode.

How to verify it

Run the tests. I added some new test cases and parametrized existing ones.

Cute Animal Picture

image

@iamdefinitelyahuman iamdefinitelyahuman force-pushed the iamdefinitelyahuman:bitwise-ops branch from b25c98e to e3176e7 Jan 2, 2020
@fubuloubu fubuloubu merged commit 4ac5ef5 into vyperlang:master Jan 2, 2020
8 checks passed
8 checks passed
lint
Details
mypy
Details
py36-core
Details
py37-core
Details
py38-core
Details
fuzzing
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.