Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify list return type check #1797

Merged
merged 1 commit into from Jan 6, 2020

Conversation

@iamdefinitelyahuman
Copy link
Contributor

iamdefinitelyahuman commented Jan 3, 2020

What I did

Simplify the type check when returning lists - closes #1691

How I did it

Copypasta

How to verify it

Run tests.

Cute Animal Picture

image

@iamdefinitelyahuman iamdefinitelyahuman force-pushed the iamdefinitelyahuman:list-return-type branch from d29da4e to 6096c45 Jan 3, 2020
Copy link
Member

fubuloubu left a comment

Weird that it was like that

@fubuloubu

This comment has been minimized.

Copy link
Member

fubuloubu commented Jan 3, 2020

Looks like @jacqueswww added in #533. Waiting on his 👍

vyper/parser/stmt.py Outdated Show resolved Hide resolved
@iamdefinitelyahuman iamdefinitelyahuman force-pushed the iamdefinitelyahuman:list-return-type branch from 6096c45 to 53fd7c6 Jan 3, 2020
Copy link
Collaborator

charles-cooper left a comment

i think this is good. waiting on @jacqueswww in case there's any odd edge cases here.

@jacqueswww

This comment has been minimized.

Copy link
Collaborator

jacqueswww commented Jan 6, 2020

This was before we could easily do direct comparisons of the type classes easily; so all good ✔️

@fubuloubu fubuloubu merged commit 21ad2f3 into vyperlang:master Jan 6, 2020
8 checks passed
8 checks passed
lint
Details
mypy
Details
py36-core
Details
py37-core
Details
py38-core
Details
fuzzing
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
@iamdefinitelyahuman iamdefinitelyahuman deleted the iamdefinitelyahuman:list-return-type branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.