Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify list return type check #1797

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

iamdefinitelyahuman
Copy link
Contributor

What I did

Simplify the type check when returning lists - closes #1691

How I did it

Copypasta

How to verify it

Run tests.

Cute Animal Picture

image

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that it was like that

@fubuloubu
Copy link
Member

Looks like @jacqueswww added in #533. Waiting on his 👍

vyper/parser/stmt.py Outdated Show resolved Hide resolved
Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is good. waiting on @jacqueswww in case there's any odd edge cases here.

@jacqueswww
Copy link
Contributor

jacqueswww commented Jan 6, 2020

This was before we could easily do direct comparisons of the type classes easily; so all good ✔️

@fubuloubu fubuloubu merged commit 21ad2f3 into vyperlang:master Jan 6, 2020
@iamdefinitelyahuman iamdefinitelyahuman deleted the list-return-type branch January 6, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible simplification for list return type checking
4 participants