re-enable msg.* env variables in internal functions#2632
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2632 +/- ##
==========================================
- Coverage 86.55% 86.54% -0.01%
==========================================
Files 92 92
Lines 9460 9456 -4
Branches 2400 2398 -2
==========================================
- Hits 8188 8184 -4
Misses 781 781
Partials 491 491
Continue to review full report at Codecov.
|
fubuloubu
reviewed
Feb 7, 2022
| c = get_contract(code) | ||
| addr = w3.eth.accounts[0] | ||
| assert c.whoami() == addr | ||
| # TODO figure out why this does not work |
fubuloubu
approved these changes
Feb 8, 2022
Contributor
fubuloubu
left a comment
fubuloubu
left a comment
There was a problem hiding this comment.
Probably needs docs updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix #2631
How I did it
Remove the restrictions, fix tests
How to verify it
Check tests
Description for the changelog
re-enable msg.* env variables in internal functions
Cute Animal Picture