fix: #31 Fix the defs bug #32
Conversation
README.md : update doc to say display none doesnt work in some cases gulpfile.js : remove display:none injector inline-svg.html : wrap injected file into hidden div inline-svg.html : add gradient circle to visually test index.js : added a global defs , remove inner symbol def
|
@pastjean thanks, we definitely have to solve this issue, I can't merge this straight away because we have to add tests and also fix my concern regarding the same ids coming from the same files. As a disclaimer, I didn't consider this to be used for complex svgs, but once we're getting into nested references, we have to make ids of svg contents unique. |
|
I'll start fixing the simple things right away then the multiple ids shouldnt be to much either! I will try fixing tests too! |
use smaller <defs/> no need of .first() on <defs/> (only one defs in svg)
|
@w0rm Everything is fixed! Even added a test for let's open a new issue for the multiple IDs thing. |
| @@ -119,6 +119,7 @@ describe('gulp-svgstore unit test', function () { | |||
| var result = file.contents.toString() | |||
| var target = | |||
| '<svg xmlns="http://www.w3.org/2000/svg">' + | |||
| '<defs/>' + | |||
There was a problem hiding this comment.
I wonder if we should not output empty in this case.
There was a problem hiding this comment.
probably , well the grunt one doesnt do , i guessed doing the same was good enough !
README.md : update doc to say display none doesnt work in some cases
gulpfile.js : remove display:none injector
inline-svg.html : wrap injected file into hidden div
inline-svg.html : add gradient circle to visually test
index.js : added a global defs , remove inner symbol def
No tests :( sorry