Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider ignoring LSP/tsserver diagnostics unless explicitly asked for #1172

Closed
w0rp opened this issue Nov 28, 2017 · 1 comment

Comments

Projects
1 participant
@w0rp
Copy link
Owner

commented Nov 28, 2017

For LSP especially, diagnostics could be sent to the client at any time, even when the client hasn't asked for them. It might be an idea to set a flag when ALE asks for files to be checked, and reset the flag the next time diagnostics appear, so ALE only updates the problems for a buffer when ALE has asked for diagnostics.

Either this will probably need to be done, or the documentation will need to be updated stating that problems could be updated for LSP linters at any time. The latter might be preferable.

@w0rp w0rp added the enhancement label Nov 28, 2017

@w0rp w0rp added the LSP label Apr 23, 2018

@w0rp w0rp added this to To do in Version 2.0 via automation Jun 20, 2018

w0rp added a commit that referenced this issue Jun 24, 2018

@w0rp w0rp closed this Jun 24, 2018

Version 2.0 automation moved this from To do to Done Jun 24, 2018

@w0rp

This comment has been minimized.

Copy link
Owner Author

commented Jun 24, 2018

Now linter results can be ignored with g:ale_linters_ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.