Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javac: Don't assume src/main/java always exists #2305

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@campbellr
Copy link
Contributor

campbellr commented Feb 18, 2019

Some projects I have only have src/test/java (no /src/main/java), which
seemed to break some incorrect assumptions the linter had.

@w0rp
Copy link
Owner

w0rp left a comment

Looks good to me. Could you add a test for this? See existing tests. You should be able to create dummy files in a directory without src/main/java and test the output of this.

@campbellr

This comment has been minimized.

Copy link
Contributor Author

campbellr commented Feb 19, 2019

Sure, I'll try to add a test.

javac: Don't assume src/main/java always exists
Some projects I have only have src/test/java (no /src/main/java), which
seemed to break some incorrect assumptions the linter had.

@campbellr campbellr force-pushed the campbellr:master branch from 156d23d to 4fc27f0 Mar 3, 2019

@campbellr

This comment has been minimized.

Copy link
Contributor Author

campbellr commented Mar 3, 2019

@w0rp I finally added a test that I believe covers this (sorry it took so long).

Let me know if there's anything else.

@w0rp

w0rp approved these changes Mar 6, 2019

@w0rp w0rp merged commit 6aef52f into w0rp:master Mar 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@w0rp

This comment has been minimized.

Copy link
Owner

w0rp commented Mar 6, 2019

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.