Add Sorbet ruby linter and fixer #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaun
force-pushed
the
feat/ruby-sorbet
branch
from
028e30c
to
f908e9a
Compare
w0rp
approved these changes
Jul 13, 2019
|
Cheers! 馃嵒 |
timlag1305
pushed a commit
to timlag1305/ale
that referenced
this pull request
Nov 5, 2019
|
@rintaun Thanks for this, I've been using it a lot. I was wondering though why you're using |
|
@will Honestly, I don't remember exactly, but as I recall it was necessary for it to work at all. That may have changed, as this was made quite a while ago, and I haven't been keeping up with the development of Sorbet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the Sorbet type checker for Ruby that was just released publicly. I basically used the
rubocoplinter as a guide, along with a couple other LSP linters, so I'm not 100% sure that I did everything (or anything? 馃槀) in the best way -- especially the tests.Thanks!