Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make search for configspec not depend on os.path #6

Merged
merged 1 commit into from Feb 7, 2019
Merged

Make search for configspec not depend on os.path #6

merged 1 commit into from Feb 7, 2019

Conversation

Wentzell
Copy link
Contributor

@Wentzell Wentzell commented Feb 6, 2019

This adjusts the search for the configspec file to search directly in the directory of config.py instead of iterating through the content of os.path

@CaptainSifff
Copy link
Contributor

CaptainSifff commented Feb 7, 2019 •
edited

@mwallerb, @alexkowalski Any opinions?

mwallerb
mwallerb approved these changes Feb 7, 2019
View reviewed changes
Copy link
Member

@mwallerb mwallerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK: I don't see how this can break installations, as we always ship the whole directory together.
Thanks Nils!

@CaptainSifff CaptainSifff merged commit d5fe3aa into w2dynamics:master Feb 7, 2019
@Wentzell Wentzell deleted the PR_SEARCH_CONFIGSPEC branch February 7, 2019 19:34
alexkowalski pushed a commit to alexkowalski/w2dynamics that referenced this pull request Nov 27, 2019
@CaptainSifff
Merge pull request w2dynamics#6 from Wentzell/PR_SEARCH_CONFIGSPEC
aa88765 
Make search for configspec not depend on os.path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwallerb mwallerb mwallerb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Wentzell @CaptainSifff @mwallerb