Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#48 fix Capitalization fix for DID spec #49

Open
wants to merge 6 commits into
base: gh-pages
from

Conversation

@mskuybeda
Copy link

mskuybeda commented Oct 25, 2019

Fixed capitalization for DID parameter

@mskuybeda mskuybeda changed the title Issue#2 fix Capitalization fix for DID spec Issue#48 fix Capitalization fix for DID spec Oct 25, 2019
Copy link
Member

peacekeeper left a comment

Thanks, this is a great start! Just a few comments: I think the title and headings should not be changed, i.e. remain in uppercase (or "Title Case" - apparently that's what it's called according to Wikipedia).

And could you also fix the remaining terms "Decentralized Identifier", "Decentralized Identifier Registry", and "Service Endpoint"?

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
mskuybeda and others added 5 commits Oct 28, 2019
Co-Authored-By: Markus Sabadello <markus@danubetech.com>
Co-Authored-By: Markus Sabadello <markus@danubetech.com>
Co-Authored-By: Markus Sabadello <markus@danubetech.com>
Co-Authored-By: Markus Sabadello <markus@danubetech.com>
Co-Authored-By: Markus Sabadello <markus@danubetech.com>
@mskuybeda

This comment has been minimized.

Copy link
Author

mskuybeda commented Nov 5, 2019

I can. Not really sure about these one:
<<And could you also fix the remaining terms "Decentralized Identifier", "Decentralized Identifier Registry", and "Service Endpoint"?>>

Do you want to make them lower case as well?

@peacekeeper

This comment has been minimized.

Copy link
Member

peacekeeper commented Nov 6, 2019

Yes I think those should be lowercase as well, except in titles or headings. To be consistent with the DID Core spec..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.