New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/operations handling, Business Rules #487
Conversation
Full understanding that there is a fair amount of re-ordering, etc with this PR, and that it will take time to review. Given how out of order several sections were, e.g. vocab pointers buried below other sections in the spec, i would request that the spec is read top to bottom to ensure correct ordering of sections, per specification norms, etc. new additions to the spec are confined to the section starting at line 358 "Rules for Processing Data" |
docs/spec/index.html
Outdated
`TraceablePresentation.workflow.instance`, assuming that the | ||
implementation's underlying data store persists presentation metadata | ||
upon receiving that data. Rules for ensuring the retrieval of the most | ||
"correct" credentails associated for that workflow instance are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the primary challenge for us to define... assuming a stream of presentations where credentials may be "replayed" or "replaced" or "updated"... what is the current state of the instance, and which credentials are most authoritative for satisfying the requirements of the definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest we build on this, after it is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, let me know when its out of draft, and I will review again.
Co-authored-by: Orie Steele <orie@or13.io>
…T /credentials/{credential-id}
…w definition and instance
Co-authored-by: Orie Steele <orie@or13.io>
Co-authored-by: Orie Steele <orie@or13.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, Mike! Thank you.
For future, separating radical re-ordering from pretty much any other change(s) makes reviewing much easier. This melange is gonna take a while to digest/understand, even if I review commit-by-commit... |
can you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only blocking feedback is related to "conversion to github issues" or "creating an issue"
174 comments. 45 commits. and counting. Most if not all without specific issues behind them. This PR has gone past my ability to usefully review, largely because GitHub doesn't know how to highlight text changes of this variety or magnitude, and, so far as I can tell, there's no PR Preview. I can't think of how to best proceed at this point. Maybe someone else has a good idea. |
Co-authored-by: Orie Steele <orie@or13.io>
Co-authored-by: Orie Steele <orie@or13.io> Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Orie Steele <orie@or13.io> Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Chris Abernethy <brownoxford@gmail.com>
I believe we now have issues open on everything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few additional issues need to be linked in respec, see:
@mprorock sorry, I should have been more clear, opening issues is good, but for "new things" they also need to be linked in the spec, I have left comments on those, and left the rest of your resolutions resolved. |
I am merging this, its massive, and we need to start addressing follow up items. |
Corrects some formatting on HTML.
Reorders sections for better readability.
Adds section around business rules handling for identifiers and common operations performed using external systems with data receiving or analyzing data presented using this spec