Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: SIMA application/license schema changes #670

Merged
merged 6 commits into from Jan 3, 2023
Merged

chore: SIMA application/license schema changes #670

merged 6 commits into from Jan 3, 2023

Conversation

acarnagey
Copy link
Collaborator

Removing optional schema fields not in the example

nissimsan
nissimsan requested changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@nissimsan nissimsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are missing example values, then the fix should be adding those values. Not removing them from the schema.

docs/openapi/components/schemas/common/SIMASteelImportLicense.yml Outdated Show resolved Hide resolved
docs/openapi/components/schemas/common/SIMASteelImportProductSpecifier.yml Show resolved Hide resolved
@OR13
Copy link
Collaborator

OR13 commented Dec 15, 2022

74ffzc

@acarnagey
Copy link
Collaborator Author

@nissimsan should these then be required fields in the schema, should we also keep inspection observation in steel product too?

@acarnagey
Copy link
Collaborator Author

@nissimsan took another pass at this, let me know if there should be some other ones I removed that should be required and added the example

@acarnagey acarnagey changed the title chore: SIMA application schema change chore: SIMA application/license schema changes Dec 15, 2022
@nissimsan
Copy link
Collaborator

Solid update, @acarnagey!

In summary:

  • Narrow the SteelProduct schema
  • Adds format: date-time
  • Tighten up the json schema test

@nissimsan nissimsan merged commit d8b9bc6 into main Jan 3, 2023
@brownoxford brownoxford deleted the feat/SIMA-schema-refactor branch January 3, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkhraisha mkhraisha mkhraisha approved these changes

@nissimsan nissimsan nissimsan approved these changes

@BenjaminMoe BenjaminMoe BenjaminMoe approved these changes

@OR13 OR13 Awaiting requested review from OR13 OR13 is a code owner

@mprorock mprorock Awaiting requested review from mprorock mprorock is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@acarnagey @OR13 @nissimsan @mkhraisha @BenjaminMoe