Skip to content
This repository was archived by the owner on Feb 25, 2026. It is now read-only.
This repository was archived by the owner on Feb 25, 2026. It is now read-only.

invalid import statement in Example #250

Closed

Description

@Jxck

https://github.com/openpeer/ortc/blob/master/ortc.html#L1036

this import is invalid. and also helper js invalid for export, even in ES6 modules.

but, in my opinion, helper is not good for Example.
each Example should complete itself for easy to understand.
and this helper seems not useful enough to add to Draft.

for example

function trace(text) {
  // This function is used for logging.
  text = text.trimRight();
  if (window.performance) {
    var now = (window.performance.now() / 1000).toFixed(3);
    console.log(now + ": " + text);
  } else {
    console.log(text);
  }
}

we don't always need to calculate performance time.
it's enough to use console.trace or console.log

function errorHandler(error) {
  trace("Error encountered: " + error.name);
}

enough to use console.error

function mySendLocalCandidate(candidate, component, kind, parameters) {
  // Set default values
  kind = kind || "all";
  component = component || RTCIceComponent.RTP;
  parameters = parameters || null;

  // Signal the local candidate
  mySignaller.mySendLocalCandidate({
    "candidate": candidate,
    "component": component,
    "kind": kind,
    "parameters": parameters
  });
}

this used in some line, but mySignaller.mySendLocalCandidate also called directory too.
this means call mySignaller.mySendLocalCandidate directory is enough, and helper is removable.

  • myIceGathererStateChange
  • myIceTransportStateChange
  • myDtlsTransportStateChange

only a message helper.
just use console.log and write a description of that event in draft(already done) is enough.

wrap up.
I think remove helper and write more understandable and complete in each section is better for draft Example.
if you agree with this, I can PR for Fix all Examples.

or if you think this helper is necessary, I think it OK but please fix import / export syntax with ES6 valid one.

thanks.

Activity

  1. robin-raymond commented on Oct 5, 2015

    @robin-raymond
    Contributor

    @Jxck Here's my proposal. We are going to check in the latest version so that all fixes are up to date. Then I plan to run through a beautifier after (suggestions as to your favourite online one?) Then you can issue pull request against the sample. You seem to have a better handle on these than us :)

  2. added a commit that references this issue on Jan 6, 2016
  3. added a commit that references this issue on Jan 7, 2016
  4. aboba commented on Jan 15, 2016

    @aboba
    Contributor

    Can someone who understands JS import/export take a look at the examples to see if they are now correct?

  5. Jxck commented on Jan 15, 2016

    @Jxck
    ContributorAuthor

    syntax seems correct to me.

  6. Jxck commented on Jan 15, 2016

    @Jxck
    ContributorAuthor

    sorry I didn't aim to close. but if it's time to close. please close it.

  7. reopened this on Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions